chore: rework mutagen controller, add polling #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
deansheather
commented
Apr 1, 2025
deansheather
commented
- Use locks during operations for daemon process consistency
- Use a state model for UI rendering
- Use events to signal state changes
- Fix some tooltip problems that arise from polling
- Use locks during operations for daemon process consistency - Use a state model for UI rendering - Use events to signal state changes - Fix some tooltip problems that arise from polling
spikecurtis
reviewed
Apr 1, 2025
App/Services/MutagenController.cs
Outdated
| _state = state; | ||
| // Since the event handlers could block (or call back the | ||
| // CredentialManager and deadlock), we run these in a new task. | ||
| if (StateChanged == null) return; |
There was a problem hiding this comment.
Don't we need to check if the state has actually changed?
There was a problem hiding this comment.
I decided not to implement equality for the state type because I would also need to implement equality for the sync session model (and all of it's sub types) which seems like a lot. I don't think there's any side effects of calling this every time it changes though
App/Services/MutagenController.cs
Outdated
| // Since the event handlers could block (or call back the | ||
| // CredentialManager and deadlock), we run these in a new task. | ||
| if (StateChanged == null) return; | ||
| Task.Run(() => { StateChanged?.Invoke(this, state); }); |
There was a problem hiding this comment.
Are Events threadsafe? If we start this in another task, could it be modified under us in a way that breaks stuff?
There was a problem hiding this comment.
I'll copy the EventHandler to a variable before calling it, which I believe makes it thread safe
spikecurtis
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.